Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changing 'Field Type' doesn't invalidate cache in JsonGenerator #405

Closed
1 task done
TobyDS opened this issue Oct 11, 2024 · 3 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@TobyDS
Copy link
Contributor

TobyDS commented Oct 11, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Description

When changing the field type after having clicked on preview or export does not cause a cache invalidation. This results in Json being given to the user which does not conform to their specification when clicking on preview/export again.

Steps to Reproduce

Include any relevant details like:

  • Go to JsonGenerator
  • Set the field names and their types
  • Open preview or click export.
  • Change one of the types without adding or removing a field, or changing the field name.
  • Click on preview or export again and observe the incorrect Json being provided

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

Update the cache checking function in utils.js to take into account a change in field type, not just field name

@TobyDS TobyDS added the bug Something isn't working label Oct 11, 2024
Copy link
Contributor

Hello! 👋 Thanks for opening this issue. We appreciate your feedback and will look into it as soon as possible. Feel free to add more details if necessary.

@TobyDS
Copy link
Contributor Author

TobyDS commented Oct 11, 2024

Proposed fix implemented in pull request #406

@Bashamega
Copy link
Owner

Thanks toby

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants