Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gh finder modal #361

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Fix/gh finder modal #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf15fb
Merge pull request #4 from Bashamega/main
Bridgetamana Oct 4, 2024
945c147
fix GH finder modal responsiveness
Bridgetamana Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/app/gh-finder/modal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ const style = {
top: "50%",
left: "50%",
transform: "translate(-50%, -50%)",
width: 600,
height: 300,
width: "90%",
maxWidth: 600,
height: 400,
border: "2px solid #000",
boxShadow: 24,
p: 4,
Expand Down Expand Up @@ -61,15 +62,17 @@ export default function BasicModal({
viewBox="0 0 24 24"
strokeWidth="2"
stroke="currentColor"
className="h-6 w-6 text-gray-500"
className="h-4 w-4 md:w-6 md:h-6 text-gray-500"
>
<path
strokeLinecap="round"
strokeLinejoin="round"
d="M3 4a1 1 0 011-1h16a1 1 0 011 1v2a1 1 0 01-.293.707L14 12.414V18a1 1 0 01-.553.894l-4 2A1 1 0 018 20v-7.586L3.293 6.707A1 1 0 013 6V4z"
/>
</svg>
<Button onClick={handleOpen}>Filter</Button>
<Button onClick={handleOpen} className="sm:!text-sm !text-[12px]">
Filter
</Button>
</Button>
<Modal
open={open}
Expand All @@ -79,11 +82,11 @@ export default function BasicModal({
>
<Box
sx={style}
className={`${
className={`sm:!h-[300px] ${
isDarkMode ? "bg-slate-800 text-white" : "bg-slate-200 text-black"
}`}
>
<FormGroup>
<FormGroup className="!grid sm:grid-cols-2">
{labelsList.map((label, idx) => (
<FormControlLabel
key={idx}
Expand Down
8 changes: 3 additions & 5 deletions src/app/gh-finder/page.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,9 @@ export default function GhFinder() {
</div>
</div>

<div className="flex justify-between w-full my-5 items-center">
<div className="flex gap-1.5 md:gap-3 w-full my-5 items-center justify-center">
<button
className={`w-full md:w-1/3 px-5 py-3 md:py-4
text-sm font-medium rounded-full transition-all duration-200 ease-in-out
className={`md:w-1/3 px-2.5 md:px-5 py-3 md:py-4 sm:text-sm text-[12px] font-medium rounded-full transition-all duration-200 ease-in-out
border border-transparent focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2
${
selected === 1
Expand All @@ -280,8 +279,7 @@ export default function GhFinder() {
Web Dev Tools Issues
</button>
<button
className={`w-full md:w-1/3 px-5 py-3 md:py-4
text-sm font-medium rounded-full transition-all duration-200 ease-in-out
className={`md:w-1/3 px-4 py-3 md:py-4 sm:text-sm text-[12px] font-medium rounded-full transition-all duration-200 ease-in-out
border border-transparent focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2
${
selected === 2
Expand Down
Loading