Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gh finder modal #361

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Fix/gh finder modal #361

merged 2 commits into from
Oct 5, 2024

Conversation

Bridgetamana
Copy link
Contributor

@Bridgetamana Bridgetamana commented Oct 4, 2024 •
edited by Bashamega
Loading

Description

This pull request addresses the non-responsive filter modal on the Github Issue Finder Page.

Fixes #358

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

Screenshot
Screenshot

@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-dev-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:58pm

Bashamega
Bashamega approved these changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@Bashamega Bashamega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@Bashamega Bashamega merged commit fe67e2c into Bashamega:main Oct 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bashamega Bashamega Bashamega approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Filter modal on GitHub issue finder page isn't responsive
2 participants
@Bridgetamana @Bashamega