Constexpr recurse #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytuo
commented
Aug 18, 2020
| FunctionDecl *CycleEntryFn = CyclicCallStack.front().Callee->getDefinition(); | ||
| // And now, for ease of understanding, let's print the call sequence that | ||
| // forms the cycle in question. | ||
| if (!CycleEntryFn->isConstexprSpecified()) { |
A7-5-2 Finds strongly connected functions (by analyzing call graph for SCC's that are loops), diagnoses each function in the cycle, and displays one example of possible call graph loop (recursion). Makes exception for constexpr functions, including lambdas implicitly marked constexpr in C++17 or later.
ytuo
force-pushed
the
constexpr-recurse
branch
from
49e9769
to
23a6a7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A7-5-2
Functions shall not call themselves from a constexpr (which is allowed).
Modeled off of misc-no-recursion. Made comments of my edits