Handle changes in XRWebGLLayer framebuffer size #9853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XRWebGLLayer's framebuffer size (and framebuffer object) are allowed to change between frames. WebXRSessionManager's IRenderTargetProvider would create a RenderTargetTexture just once, so it would miss changes coming from WebXR.
RaananW
approved these changes
Jan 27, 2021
Indeed the WebXR emulator doesn't have a way to change the number of views (beyond 1-2) or the framebuffer size. That control is specific to my project which outputs to a Looking Glass display, which can display an arbitrary number of different angles in a 30 degree "cone" around the display. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRWebGLLayer's framebuffer size (and framebuffer object) are allowed to
change between frames. WebXRSessionManager's IRenderTargetProvider would
create a RenderTargetTexture just once, so it would miss changes coming
from WebXR.
Obviously I have no idea if this is the right fix, but it works :)
Guidance would be appreciated.
I found this bug while working on a personal project:
https://github.com/kainino0x/holoplay-webxr
It is possible to verify this fix by loading the Babylon playground with this browser extension installed, entering XR, then changing the "number of views to render".