fix: vertically interlaced stereoscopic rendering #9562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_MODE_STEREOSCOPIC_INTERLACED` not working (BabylonJS#8000, BabylonJS#7425)
RaananW
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Rig mode for vertically interlaced stereoscopic rendering
RIG_MODE_STEREOSCOPIC_INTERLACEDwas first implemented in #7425 (forum discussion), and likely inadvertently removed in #8001 (dc0e816).Current Behavior
RIG_MODE_STEREOSCOPIC_INTERLACEDcurrently renders identical toRIG_MODE_STEREOSCOPIC_OVERUNDER(playground link). Inquiry was made with @RaananW in #8000.New Behavior
These changes should preserve the correct behavior of
RIG_MODE_STEREOSCOPIC_SIDEBYSIDE_PARALLEL,RIG_MODE_STEREOSCOPIC_SIDEBYSIDE_CROSSEYED,RIG_MODE_STEREOSCOPIC_OVERUNDER, while adding back in support forRIG_MODE_STEREOSCOPIC_INTERLACEDtaken from original commits by @bilkusg (7830702).Screenshot:
Please let me know if any adjustments are required, and thanks for making this fantastic library!