Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for KHR_materials_unlit to glTF loader #4021

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Add support for KHR_materials_unlit to glTF loader #4021

merged 2 commits into from
Mar 28, 2018

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Mar 26, 2018

Bringing this back again. See KhronosGroup/glTF#1163 for discussion.

@bghgary bghgary requested a review from sebavan March 26, 2018 20:26
sebavan
sebavan requested changes Mar 27, 2018
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a tests ?

@bghgary bghgary force-pushed the KHR_materials_unlit branch from 67236c1 to cb7406b Compare March 28, 2018 16:57
@bghgary
Copy link
Contributor Author

bghgary commented Mar 28, 2018

Added a validation test.

@deltakosh deltakosh merged commit 63649a1 into BabylonJS:master Mar 28, 2018
@bghgary bghgary deleted the KHR_materials_unlit branch March 28, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bghgary @sebavan @deltakosh