Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple models support #16143

Merged

Conversation

alexandremottet
Copy link
Contributor

@alexandremottet alexandremottet commented Feb 4, 2025

Add support for multiple model on the same scene by :

  • adding a private _loadedModelBacking to reference all the model loaded on the scene,
  • renaming _modelInfo to _activeModelBacking to represent to current active/selected model
  • adding as protected a _addModel and a _removeModel

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

@RaananW RaananW requested a review from ryantrem February 4, 2025 15:59
packages/tools/viewer/src/viewer.ts Outdated Show resolved Hide resolved
packages/tools/viewer/src/viewer.ts Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 4, 2025

@ryantrem ryantrem merged commit 7621a0e into BabylonJS:master Feb 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants