Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore backwards-compatible logic paths in KHR_texture_transform #16115

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

alexchuber
Copy link
Contributor

For reference on what was previously there, see https://github.com/BabylonJS/Babylon.js/blame/83125ed754242d58f5637bde58fb2b5c26ac552a/packages/dev/serializers/src/glTF/2.0/Extensions/KHR_texture_transform.ts.

Note that preExportTextureAsync does NOT prevent the export of "noncompliant" textures, just warns about them. The only thing preventing their export would have been in postExportTexture, canUseExtension.

While it is probably more correct to prevent export when vAng or uAng are present, since we cannot match the visual output, let's prioritize backwards compatibility.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@alexchuber alexchuber marked this pull request as ready for review January 27, 2025 22:12
@deltakosh deltakosh enabled auto-merge (squash) January 27, 2025 22:12
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

@deltakosh deltakosh merged commit 0e23e9b into BabylonJS:master Jan 27, 2025
13 of 14 checks passed
@alexchuber alexchuber deleted the khr-texture-transform-fix branch February 7, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants