ShadowGenerator: add doNotSerialize #16105
Conversation
The value of this field should be used in ShadowGeneratorSceneComponent.serialize method. Part of <https://forum.babylonjs.com/t/shadowgenerators-serialized-without-light/56134>
ShadowGeneratorSceneComponent.serialize uses `light.getShadowGenerators()` which return value is `Nullable<Map<Nullable<Camera>, IShadowGenerator>>`, so doNotSerialize is needed here. It's marked as optional field to avoid breaking changes.
This commit should skip shadowGenerator serialization if its light has `doNotSerialize=true` , or itself has `doNotSerialize=true`. This fixes <https://forum.babylonjs.com/t/shadowgenerators-serialized-without-light/56134>.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16105/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16105/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16105/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
This PR adds doNotSerialize to
ShadowGeneratorandIShadowGenerator(optional field forIShadowGeneratorto avoid being breaking).Also, in
ShadowGeneratorSceneComponentserialization of aShadowGeneratorwould be skipped if it hasdoNotSerialize=true, or its light hasdoNotSerialize=true.This should fix https://forum.babylonjs.com/t/shadowgenerators-serialized-without-light/56134.