Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GREASED_LINE_USE_OFFSETS - WebGPU fix for Safari/Firefox #16053

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

RolandCsibrei
Copy link
Contributor

@RolandCsibrei RolandCsibrei commented Jan 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from Popov72 January 9, 2025 23:16
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RolandCsibrei
Copy link
Contributor Author

RolandCsibrei commented Jan 9, 2025

@Popov72 The shaders can be simplified even more. I'll do it tomorrow.

@RolandCsibrei RolandCsibrei marked this pull request as draft January 9, 2025 23:18
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@RolandCsibrei
Copy link
Contributor Author

RolandCsibrei commented Jan 10, 2025

@Popov72 The shaders can be simplified even more. I'll do it tomorrow.

I thought I could optimize the shaders by removing the var grlPositionOffset = vec3f(0.); part and perform adding the offset only when there is an grl_offsets attribute present but I have just read about the WGSL compiler's constant folding optimization technique so I'll rather prefer readibility of the shader and decided not to add several #ifdefs to the shaders. PR is ready to review.

@RolandCsibrei RolandCsibrei marked this pull request as ready for review January 10, 2025 03:36
@RolandCsibrei RolandCsibrei requested a review from Popov72 January 10, 2025 10:48
@Popov72 Popov72 merged commit 0a9b67c into BabylonJS:master Jan 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants