-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GREASED_LINE_USE_OFFSETS - WebGPU fix for Safari/Firefox #16053
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
@Popov72 The shaders can be simplified even more. I'll do it tomorrow. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16053/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
I thought I could optimize the shaders by removing the |
See #16045
With
offsets
:Simple shader material: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge#H1LRZ3#717
Material plugin: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge#H1LRZ3#122
Without
offsets
:Simple shader material: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge#406E3H#29
Material plugin: https://playground.babylonjs.com/?snapshot=refs/pull/16053/merge#406E3H#23
Tested on MacOS Chrome and Safari, WebGL and WebGPU.