Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameGraph: refactor pass / passCube post processes for frame graph usage #16051

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 9, 2025

I also factored some code for the node render graph post processes, to limit code duplication.

This is a prerequisite for converting the highlight layer into a frame graph task, as it uses internal pass-through post-processing.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 9, 2025

@sebavan sebavan merged commit c610279 into BabylonJS:master Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants