-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take new viewer out of preview/alpha #16049
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Reviewer - this PR has made changes to one or more package.json files. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16049/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16049/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16049/merge#BCU1XR#0 |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
@@ -17,7 +17,7 @@ | |||
"shared-ui-components/*": ["dev/sharedUiComponents/dist/*"], | |||
"node-editor/*": ["tools/nodeEditor/dist/*"], | |||
"gui-editor/*": ["tools/guiEditor/dist/*"], | |||
"viewer/*": ["tools/viewer/dist/*"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reasons for this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I'm not sure if we need these anymore... @RaananW?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, unless we are planning on embedding the viewer in the inspector
Overall this change removes the ES6 and UMD builds of the legacy viewer (new builds will not be published, but old ones are still available, and same goes for the CDN), renames some directories to make the new viewer be the main viewer directory, and the new viewer is published as @babylonjs/viewer (not -alpha version suffix or @Preview tag).
Remove public/@babylonjs/viewer
Remove public/umd/babylonjs-viewer
Rename tools/viewer to tools/viewer-legacy
Remove babylonjs-viewer from the umd build
Rename public/@babylonjs/viewer-alpha to public/@babylonjs/viewer
Rename tools/viewer-alpha to tools/viewer
Update readme to remove references to -alpha and @Preview
Delete the package.json patching script
Update various references to file paths based on the above changes