Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take new viewer out of preview/alpha #16049

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

ryantrem
Copy link
Member

@ryantrem ryantrem commented Jan 8, 2025

Overall this change removes the ES6 and UMD builds of the legacy viewer (new builds will not be published, but old ones are still available, and same goes for the CDN), renames some directories to make the new viewer be the main viewer directory, and the new viewer is published as @babylonjs/viewer (not -alpha version suffix or @Preview tag).

  • Remove public/@babylonjs/viewer

  • Remove public/umd/babylonjs-viewer

  • Rename tools/viewer to tools/viewer-legacy

  • Remove babylonjs-viewer from the umd build

  • Rename public/@babylonjs/viewer-alpha to public/@babylonjs/viewer

  • Rename tools/viewer-alpha to tools/viewer

  • Update readme to remove references to -alpha and @Preview

  • Delete the package.json patching script

  • Update various references to file paths based on the above changes

@ryantrem ryantrem requested a review from RaananW January 8, 2025 19:55
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2025

Reviewer - this PR has made changes to one or more package.json files.

@ryantrem ryantrem enabled auto-merge (squash) January 8, 2025 20:02
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 8, 2025

@ryantrem ryantrem merged commit 38e547c into BabylonJS:master Jan 8, 2025
13 of 14 checks passed
@@ -17,7 +17,7 @@
"shared-ui-components/*": ["dev/sharedUiComponents/dist/*"],
"node-editor/*": ["tools/nodeEditor/dist/*"],
"gui-editor/*": ["tools/guiEditor/dist/*"],
"viewer/*": ["tools/viewer/dist/*"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reasons for this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm not sure if we need these anymore... @RaananW?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, unless we are planning on embedding the viewer in the inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants