Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how we delete massive group of animatables from animationgroup #13641

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Improve how we delete massive group of animatables from animationgroup #13641

merged 5 commits into from
Mar 21, 2023

Conversation

deltakosh
Copy link
Contributor

@deltakosh deltakosh commented Mar 20, 2023 •
edited by sebavan
Loading

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan enabled auto-merge March 20, 2023 21:20
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 20, 2023

Snapshot stored with reference name:
refs/pull/13641/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13641/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13641/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13641/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13641/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13641/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13641/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13641/merge#BCU1XR#0

@sebavan sebavan merged commit d46cbb0 into master Mar 21, 2023
@sebavan sebavan deleted the animation-dispose-optimization branch March 21, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 left review comments

@RaananW RaananW RaananW left review comments

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
animations enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deltakosh @bjsplat @RaananW @Popov72 @sebavan