Button3D: Allow setting the dimensions at creation time #13637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.babylonjs.com/t/holographicbutton-button3d-sizes/39134/3
The dimensions can be set at creation time only because it has an impact on the creation of the mesh. I would have to recreate the mesh if we allowed the dimensions to be changed at any time, but
_createNode
(which creates the mesh) is called byControl3D
, and the result of that call is stored in a private variable. If the user wants to change the dimensions afterwards, he will have to recreate the button.