Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button3D: Allow setting the dimensions at creation time #13637

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Button3D: Allow setting the dimensions at creation time #13637

merged 2 commits into from
Mar 20, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Mar 20, 2023

See https://forum.babylonjs.com/t/holographicbutton-button3d-sizes/39134/3

The dimensions can be set at creation time only because it has an impact on the creation of the mesh. I would have to recreate the mesh if we allowed the dimensions to be changed at any time, but _createNode (which creates the mesh) is called by Control3D, and the result of that call is stored in a private variable. If the user wants to change the dimensions afterwards, he will have to recreate the button.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 20, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 20, 2023

@sebavan sebavan merged commit c29a327 into BabylonJS:master Mar 20, 2023
@Popov72 Popov72 deleted the gui3d-button-dimensions branch April 20, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants