Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal StackPanel width calculation when a child has forceRes… #13610

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Mar 8, 2023

…izeWidth true and fix text block line width calculation rounding.

This deals with two cases:

  1. Removes the warning appearing in https://playground.babylonjs.com/#XCPP9Y#17811 when a text block with resizeToFit and forceResizeWidth is inside an horizontal Stack Panel
  2. Fixes the layout cycle error and ellipsis wrapping in the example where a text block is sized down and sized up inside an horizontal Stack Panel: https://playground.babylonjs.com/#XCPP9Y#17810

…izeWidth true and fix text block line width calculation rounding.
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 8, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 8, 2023

@sebavan sebavan merged commit 83bbdfb into BabylonJS:master Mar 9, 2023
@carolhmj carolhmj deleted the fixesGUIWidthCalculations branch July 19, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants