Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and improve logic for instantiating nodes in AssetContainer.… #13584

Merged
merged 3 commits into from
Mar 3, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Mar 3, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 3, 2023

packages/dev/core/src/assetContainer.ts Outdated Show resolved Hide resolved
packages/dev/core/src/assetContainer.ts Outdated Show resolved Hide resolved
@sebavan sebavan merged commit dd95fbc into BabylonJS:master Mar 3, 2023
@carolhmj carolhmj deleted the fixAssetContainerInstantiation2 branch July 19, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants