Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceInputSystem: Use correct pointerId for touch inputs on blur and pointercancel event #13516

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

PolygonalSun
Copy link
Contributor

@PolygonalSun PolygonalSun commented Feb 9, 2023

A forum user recently found an issue where the pointerId was incorrect for blur and pointercancel events fired from a touch input. This PR adds a small change to the DeviceEventFactory to use the pointerId, if available.

Forum Link: https://forum.babylonjs.com/t/distinguish-between-onbuttonup-events-in-basecamerapointersinput/37985/1

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

@PolygonalSun PolygonalSun requested a review from RaananW February 9, 2023 17:15
@PolygonalSun PolygonalSun merged commit b403ab1 into BabylonJS:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants