Optimizing performance of _BinaryWriter._resizeBuffer #13456
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13456/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13456/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13456/merge#BCU1XR#0 |
In class _BinaryWriter of the gltf exporter, a loop is used to copy contents in old buffer to new buffer, which is benchmarked to be slow. TypedArray.prototype.set() can be used for faster memory copying while having the same Browser compatibility of TypedArray. Forum link: https://forum.babylonjs.com/t/optimizing-performance-of-binarywriter-resizebuffer/37516
myfreeer
force-pushed
the
binary-writer-resize-buffer
branch
from
5ad54c3 to
5e8ad0b
Compare
In class _BinaryWriter of the gltf exporter, a loop is used to copy contents in old buffer to new buffer, which is benchmarked to be slow. TypedArray.prototype.set() can be used for faster memory copying while having the same Browser compatibility of TypedArray.
Forum link:
https://forum.babylonjs.com/t/optimizing-performance-of-binarywriter-resizebuffer/37516
Benchmark before:
playground.babylonjs.com
Benchmark after:
playground.babylonjs.com