Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch release detection to draggable parts of BoundingBoxGizmo #13428

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

Hsifnus
Copy link

@Hsifnus Hsifnus commented Jan 10, 2023

As a followup from this thread on the BabylonJS forums, this PR adds touch release detection to the draggable components (scale boxes, rotation spheres) of the BoundingBoxGizmo such that those parts will now unhighlight correctly when releasing touch while dragging said parts.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 10, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 10, 2023

…nTouchUp similar that in Tools.GetPointerPrefix
@sebavan sebavan requested a review from RaananW January 11, 2023 15:45
…o cover WebXR and remove mobile safari hack
@Hsifnus Hsifnus requested review from RaananW and removed request for CedricGuillemet January 13, 2023 00:02
@sebavan sebavan merged commit 0fdd7b8 into BabylonJS:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants