Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NME: Add a RealTime input #13418

Merged
merged 3 commits into from
Jan 6, 2023
Merged

NME: Add a RealTime input #13418

merged 3 commits into from
Jan 6, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 6, 2023

@Popov72 Popov72 added new feature nme Node Material Editor labels Jan 6, 2023
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pressed the wrong button in the review... my bad and can not seem to find a way to delete...

@sebavan sebavan self-requested a review January 6, 2023 15:53
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use perfomance.now instead of Date ???

This would help with precision

@sebavan
Copy link
Member

sebavan commented Jan 6, 2023

@Popov72 sorry, I meant this one https://github.com/sebavan/Babylon.js/blob/master/packages/dev/core/src/Misc/precisionDate.ts#L10 :-)

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13418/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan enabled auto-merge January 6, 2023 18:47
@sebavan sebavan merged commit f961295 into BabylonJS:master Jan 6, 2023
@Popov72 Popov72 deleted the nme-realtime branch April 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature nme Node Material Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants