Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI Editor Line Gizmo Improvements #13394

Merged
merged 14 commits into from
Jan 4, 2023
Merged

GUI Editor Line Gizmo Improvements #13394

merged 14 commits into from
Jan 4, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Jan 3, 2023

This PR introduces functionality to move, drag endpoints and rotate the Lines Gizmo on the GUI Editor.

Without the change:
current-line-gizmo-behavior

With the change:
new-line-gizmo-behavior

@sebavan sebavan requested a review from RaananW January 3, 2023 15:13
RaananW
RaananW reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! great work. Just a few comments and a build issue :-)

packages/tools/guiEditor/src/diagram/gizmoLine.tsx Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/diagram/gizmoLine.tsx Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/diagram/gizmoLine.tsx Outdated Show resolved Hide resolved
packages/tools/guiEditor/src/diagram/gizmoLine.tsx Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 4, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@carolhmj
Copy link
Contributor Author

carolhmj commented Jan 4, 2023

@RaananW thanks for the comments, updated the code based on them! :D

@carolhmj carolhmj requested a review from RaananW January 4, 2023 20:00
@bjsplat
Copy link
Collaborator

bjsplat commented Jan 4, 2023

Snapshot stored with reference name:
refs/pull/13394/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13394/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13394/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13394/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13394/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13394/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13394/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13394/merge#BCU1XR#0

@sebavan sebavan merged commit 477d7d6 into BabylonJS:master Jan 4, 2023
@carolhmj carolhmj deleted the GEFixLineGizmo branch July 19, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
enhancement gui editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carolhmj @bjsplat @RaananW @sebavan