Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When rendering in a multi-canvas setup, always render the input view … #13320

Merged
merged 2 commits into from
Dec 7, 2022
Merged

When rendering in a multi-canvas setup, always render the input view … #13320

merged 2 commits into from
Dec 7, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Dec 6, 2022

…last, so that the canvas size is set correctly for later picks.
@carolhmj carolhmj added the bug label Dec 6, 2022
@sebavan sebavan requested review from Popov72 and RaananW December 6, 2022 17:37
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we should use bitmap renderer context whenever available to prevent the copy ?

@carolhmj carolhmj requested review from RaananW and Popov72 December 7, 2022 17:13
@sebavan sebavan enabled auto-merge December 7, 2022 17:19
@sebavan sebavan merged commit 7308fab into BabylonJS:master Dec 7, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
When rendering in a multi-canvas setup, always render the input view …

Former-commit-id: c0c6c8a31b439a2b5d2ff6d8ff0ff9df41c9f419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants