Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTXDecoder: Update and add new universal transcoders #13284

Merged
merged 6 commits into from
Nov 28, 2022
Merged

KTXDecoder: Update and add new universal transcoders #13284

merged 6 commits into from
Nov 28, 2022

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 24, 2022

Fixes #12002

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I know nothing regarding this area so lets wait on @bghgary review :-)

@sebavan sebavan enabled auto-merge November 25, 2022 00:47
@sebavan sebavan disabled auto-merge November 25, 2022 00:47
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval - Just for the changes for the public server :-)

The rest is for @bghgary

@bghgary
Copy link
Contributor

bghgary commented Nov 28, 2022

Are the new WASM files compatible with old code? Do we need to host a second version like we did for the Basis transcoders?

@Popov72
Copy link
Contributor Author

Popov72 commented Nov 28, 2022

No, the new WASM files (at least the RGBA transcoders) are not compatible with the old code. I'm going to rename them.

@sebavan sebavan merged commit 7e3ed2b into BabylonJS:master Nov 28, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
KTXDecoder: Update and add new universal transcoders
Former-commit-id: 2e2e2b38a5d53e517f2c9cb416dbbb0237841a2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to v0.2.0 of Basis-Universal-Transcoders to decode KTX
4 participants