-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KTXDecoder: Update and add new universal transcoders #13284
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13284/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13284/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13284/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I know nothing regarding this area so lets wait on @bghgary review :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval - Just for the changes for the public server :-)
The rest is for @bghgary
Are the new WASM files compatible with old code? Do we need to host a second version like we did for the Basis transcoders? |
No, the new WASM files (at least the RGBA transcoders) are not compatible with the old code. I'm going to rename them. |
KTXDecoder: Update and add new universal transcoders Former-commit-id: 2e2e2b38a5d53e517f2c9cb416dbbb0237841a2c
Fixes #12002