Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static Reflect function to Vector3 #13281

Merged
merged 5 commits into from
Nov 28, 2022

Conversation

AlvaroHerreroDev
Copy link
Contributor

This adds a static function to Vector3 to Reflect a vector off the plane defined by a normal

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

packages/dev/core/src/Maths/math.vector.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Maths/math.vector.ts Outdated Show resolved Hide resolved
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the little doc to add and good to go :-)

@sebavan
Copy link
Member

sebavan commented Nov 28, 2022

@AlvaroHerreroDev can you add the normalized comment to the doc of the normal parameter ?

@sebavan sebavan enabled auto-merge November 28, 2022 18:27
@sebavan sebavan requested a review from Popov72 November 28, 2022 18:56
@sebavan sebavan merged commit 7c04373 into BabylonJS:master Nov 28, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Add static Reflect function to Vector3

Former-commit-id: e9350ee7550c28651b5d396c9cb304b7d58ef8cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants