Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing billboardMode mode for instanced meshes #13265

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fixing billboardMode mode for instanced meshes #13265

merged 1 commit into from
Nov 18, 2022

Conversation

Bastl34
Copy link
Contributor

@Bastl34 Bastl34 commented Nov 18, 2022

Hi.
This PR is fixing an issue with the billboardMode for instanced objects.
It was sometimes undefined which was causing the instancedMesh to use the rotation of the source transformation.

Here is a simple demo of this issue:
https://playground.babylonjs.com/#9NN1BK#1

If you uncomment the "FIX" it's working as expected (only the source mesh is rotating)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan requested a review from Popov72 November 18, 2022 16:34
@sebavan sebavan merged commit 20c4b14 into BabylonJS:master Nov 18, 2022
@sebavan
Copy link
Member

sebavan commented Nov 18, 2022

Thanks a lot :-)

RaananW pushed a commit that referenced this pull request Dec 9, 2022
fixing billboardMode mode for instanced meshes

Former-commit-id: 779ee000f449c643b8ce5db11d1f0e056e5147de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants