Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks #13231

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Fix memory leaks #13231

merged 2 commits into from
Nov 13, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Nov 11, 2022

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit cbbd1a2 into BabylonJS:master Nov 13, 2022
@sebavan
Copy link
Member

sebavan commented Nov 13, 2022

I approved and merged but just noticed there are no dispose on the textures @RaananW ?

@RaananW RaananW deleted the fixMemoryLeaks branch November 14, 2022 11:28
@RaananW
Copy link
Member Author

RaananW commented Nov 14, 2022

I approved and merged but just noticed there are no dispose on the textures @RaananW ?

Addressed in #13235
Thanks!

RaananW pushed a commit that referenced this pull request Dec 9, 2022
Fix memory leaks

Former-commit-id: 46b3d5f2adaefa74c9e5317906f3b4fdeb21300b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants