Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animatable loop #13196

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Fix animatable loop #13196

merged 9 commits into from
Nov 3, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Nov 3, 2022

In this playground https://playground.babylonjs.com/#7V0Y1I#2446 we can see the animation triggering a loop on each click before the fix

@sebavan sebavan requested a review from deltakosh November 3, 2022 00:41
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13196/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13196/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13196/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13196/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13196/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13196/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13196/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13196/merge#BCU1XR#0

Popov72
Popov72 approved these changes Nov 3, 2022
View reviewed changes
packages/dev/core/src/Animations/animatable.ts Outdated Show resolved Hide resolved
@sebavan sebavan enabled auto-merge November 3, 2022 17:12
@sebavan sebavan merged commit eebb704 into BabylonJS:master Nov 3, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13196 from sebavan/master
597de25 
Fix animatable loop

Former-commit-id: 17b61383664f26d2498aeb77858c7b5c4d9ce88b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
animations bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebavan @deltakosh @Popov72