Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vector2 type to custom inspector properties #13141

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Add Vector2 type to custom inspector properties #13141

merged 2 commits into from
Oct 20, 2022

Conversation

BlakeOne
Copy link
Contributor

Add Vector2 type to custom inspector properties

@BlakeOne BlakeOne marked this pull request as draft October 20, 2022 16:14
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Popov72
Popov72 approved these changes Oct 20, 2022
View reviewed changes
packages/dev/core/src/Misc/iInspectable.ts Outdated Show resolved Hide resolved
@BlakeOne BlakeOne marked this pull request as ready for review October 20, 2022 16:36
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13141/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13141/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13141/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13141/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13141/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13141/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13141/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13141/merge#BCU1XR#0

@sebavan sebavan enabled auto-merge October 20, 2022 17:09
@sebavan sebavan merged commit 46d45e1 into BabylonJS:master Oct 20, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13141 from BlakeOne/master
a02fba1 
Add Vector2 type to custom inspector properties

Former-commit-id: 798a5157943f9d4809405369f9ef0b0f8983b75d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@Popov72 Popov72 Popov72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BlakeOne @Popov72 @sebavan