Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputManager: Fix for POINTERTAP firing when cursor is moved #13136

Merged
merged 3 commits into from
Oct 19, 2022
Merged

InputManager: Fix for POINTERTAP firing when cursor is moved #13136

merged 3 commits into from
Oct 19, 2022

Conversation

PolygonalSun
Copy link
Contributor

This PR contains a fix for the InputManager to not erroneously treat a pointerup event as a POINTERTAP if the cursor has moved outside of the drag threshold, even if it returns to the exact same point.

This fix should address this bug: https://github.com/BabylonJS/ThePirateCove/issues/168

@PolygonalSun PolygonalSun marked this pull request as ready for review October 19, 2022 19:31
@sebavan
Copy link
Member

sebavan commented Oct 19, 2022

Please wait for at least another reviewer before merging :-)

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13136/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13136/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13136/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13136/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13136/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13136/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13136/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13136/merge#BCU1XR#0

@PolygonalSun PolygonalSun merged commit 878b351 into BabylonJS:master Oct 19, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@PolygonalSun
InputManager: Fix for POINTERTAP firing when cursor is moved (#13136)
aa13253 
* Modify isPointerSwiping to check for moving

* format

Former-commit-id: 29c590dc97e8e12e89609e330e1d72db9fba270c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

@sebavan sebavan sebavan approved these changes

@deltakosh deltakosh Awaiting requested review from deltakosh

Assignees
No one assigned
Labels
enhancement inputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PolygonalSun @sebavan @bghgary