Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to enable/disable auto-build of the DefaultRenderingPipeline. #13121

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

kircher1
Copy link
Contributor

I use this to perform some custom setup after the DefaultRenderingPipeline is constructed; I construct the pipeline with auto-build disabled (to avoid it's ctor creating effects which will need to be recreated), then perform some setup, and finally prepare() and re-enable the pipeline's automaticBuild.

Prior to this change, I wasn't able to turn the automaticBuild back on so would have either had to track effect changes manually or live with unneeded effect creation in the ctor.

Other minor cleanup included.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 5150fa3 into BabylonJS:master Oct 17, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Add API to enable/disable auto-build of the DefaultRenderingPipeline.

Former-commit-id: 4057ec5815a6d7339f9da914748e032ec1454369
@kircher1 kircher1 deleted the default-pipeline-auto-build branch September 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants