Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] fix the samples returned when using multiview in WebXR #13108

Merged
merged 2 commits into from
Oct 13, 2022
Merged

[XR] fix the samples returned when using multiview in WebXR #13108

merged 2 commits into from
Oct 13, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 13, 2022

When using multiview on WebXR I don't want to update the samples using setSamples because of the extra work done there (that is not needed).
This is one solution. A different one would be to introduce a (hidden) setter to the _samples of the wrapper but this approach makes sure the state of the wrapper doesn't change.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 4f8778b into BabylonJS:master Oct 13, 2022
@RaananW RaananW deleted the webXRMultiviewSamplesFix branch October 13, 2022 19:08
RaananW pushed a commit that referenced this pull request Dec 9, 2022
[XR] fix the samples returned when using multiview in WebXR

Former-commit-id: 75c4edc64a874bfac4195152464545c073f30d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants