Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostProcessRenderPipeline: Made _renderEffects protected to allow subclassing #13095

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

BarthPaleologue
Copy link
Contributor

It is not possible to manipulate the render effects in subclasses of PostProcessRenderPipeline so making these attributes protected can do the trick.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan enabled auto-merge October 11, 2022 14:42
@sebavan sebavan merged commit b671313 into BabylonJS:master Oct 11, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
`PostProcessRenderPipeline`: Made `_renderEffects` protected to allow subclassing

Former-commit-id: b49dbb9ad3d12e053b78825fb734f6052f5d62bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants