Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] deal with dead codes correctly #13064

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[GUI] deal with dead codes correctly #13064

merged 2 commits into from
Oct 5, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 5, 2022

Playground: #I1Y5YT#47

This treats dead code as expected minus a few modifiers that are not available in a keyboard event. For example - on a supporting keyboard - when entering a quote (") and A afterwards we should output ä, but the expected result if entering " and f (for example) afterwards is: "f. This is not provided in the event. Threfore we are using the default behavior, which is output the dead key if space was entered right after.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some console logs in the wild otherwise very nice! :D

packages/dev/gui/src/2D/controls/inputText.ts Outdated Show resolved Hide resolved
packages/dev/gui/src/2D/controls/inputText.ts Outdated Show resolved Hide resolved
@RaananW RaananW requested a review from carolhmj October 5, 2022 13:57
@sebavan sebavan enabled auto-merge October 5, 2022 15:01
@sebavan sebavan merged commit a9ed471 into BabylonJS:master Oct 5, 2022
@RaananW RaananW deleted the deadKeysTextInput branch October 5, 2022 17:30
RaananW pushed a commit that referenced this pull request Dec 9, 2022
[GUI] deal with dead codes correctly

Former-commit-id: f3758410a2ffc590fe17a66549795ea69839b560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants