Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add applyPostProcess flag on ADV to optionally draw it after the post… #13036

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Add applyPostProcess flag on ADV to optionally draw it after the post… #13036

merged 4 commits into from
Sep 28, 2022

Conversation

carolhmj
Copy link
Contributor

… processes have been applied.

Thanks Seb for the guidance :D

Some Playground examples:
#FBH4J7#144
#J9H084#392 (has renderTarget)

@carolhmj carolhmj requested review from Popov72 and sebavan September 27, 2022 20:04
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13036/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13036/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13036/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13036/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13036/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13036/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13036/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13036/merge#BCU1XR#0

Popov72
Popov72 approved these changes Sep 27, 2022
View reviewed changes
packages/dev/core/src/Layers/layer.ts Outdated Show resolved Hide resolved
sebavan
sebavan approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment than @Popov72 tiny fix in the doc only :-)

deltakosh
deltakosh approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok just a tiny nit for the comment and we are good to go

@sebavan
Copy link
Member

sebavan commented Sep 28, 2022

Wondering like David if there is something easier to read for the various conditions ?

@sebavan sebavan enabled auto-merge September 28, 2022 18:35
@sebavan sebavan merged commit 075b8c1 into BabylonJS:master Sep 28, 2022
@carolhmj carolhmj deleted the renderUIAfterPostProcesses branch October 20, 2022 12:49
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@sebavan
Merge pull request #13036 from carolhmj/renderUIAfterPostProcesses
fec9648 
Add applyPostProcess flag on ADV to optionally draw it after the post…

Former-commit-id: 65b48dad5fdd605ecf428c00938c1df2939a9309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

@Popov72 Popov72 Popov72 approved these changes

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carolhmj @sebavan @deltakosh @Popov72