-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More features for the aggressive performance mode #13014
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13014/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/13014/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/13014/merge#BCU1XR#0 |
* Gets or sets a boolean indicating that the manager will not reset between frames. | ||
* This means that if a mesh becomes invisible or transparent it will not be visible until this boolean is set to false again.s | ||
*/ | ||
public maintainStateBetweenFrames = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you will need a setter that will reset all the _wasDispatched
properties to false
when maintainStateBetweenFrames
is switched from true
to false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this is a good catch! PR is coming!
Former-commit-id: c855d23a3aca8bf7a644128d6dd697bd22254853
Some tiny perf changes + a major one: Now in aggressive mode, the renderingGroups are not reset between frames.