Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XR] Fix typings for the options passed #12994

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[XR] Fix typings for the options passed #12994

merged 1 commit into from
Sep 19, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Sep 19, 2022

They options passed are augmented with the required members, so there is no need to define them fully. Partial of those options is enough.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 0a09c4c into BabylonJS:master Sep 19, 2022
@RaananW RaananW deleted the xrOptionsTypings branch September 19, 2022 14:11
RaananW pushed a commit that referenced this pull request Dec 9, 2022
[XR] Fix typings for the options passed

Former-commit-id: fecc5134437c68f142084bb7026ae82071f4c54e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants