PrePass renderer: Fix engine current render pass id set too early #12988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://forum.babylonjs.com/t/issue-when-prepassrenderer-and-rendertargettexture-are-used-at-the-same-time/29317/7
Basically it's a revert of my changes from:
269132c#diff-5fec6a90573f71adda2b2d7c9364ac6da73fe8cfc6a641b129a051bf38d67cd2
I don't remember why I did this change at that time, I think it's wrong to set
Engine.currentRenderPassId
inPrePassRenderer._setRenderTarget
asRenderTargetTexture._renderToTarget
will set the right pass id before drawing the meshes anyway.[EDIT] Ok, I updated the fix which is not simply a revert now: the
engine.currentRenderPassId
needs to be updated but only when setting the default RT.