Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate sampler name in buildBlock #12913

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Generate sampler name in buildBlock #12913

merged 2 commits into from
Aug 30, 2022

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj added the bug label Aug 29, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12913/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12913/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12913/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12913/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12913/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12913/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12913/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12913/merge#BCU1XR#0

@carolhmj carolhmj requested a review from Popov72 August 30, 2022 11:16
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12913/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12913/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12913/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12913/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12913/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12913/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12913/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12913/merge#BCU1XR#0

@RaananW RaananW merged commit 83cf5b9 into BabylonJS:master Aug 30, 2022
@carolhmj carolhmj deleted the fixSceneDepthBlock branch September 2, 2022 17:30
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@carolhmj
Generate sampler name in buildBlock (#12913)
45c3716 
* Generate sampler name in buildBlock

* Review update.

Former-commit-id: b04081bb81e910fd28c77b1adc5ecef1a8092526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

@Popov72 Popov72 Awaiting requested review from Popov72

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolhmj @RaananW @Popov72