Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type on blob creation #12912

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Add type on blob creation #12912

merged 2 commits into from
Aug 30, 2022

Conversation

carolhmj
Copy link
Contributor

This fixes loading of SVG Textures

@carolhmj carolhmj added the bug label Aug 29, 2022
RaananW
RaananW approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@carolhmj carolhmj requested a review from RaananW August 29, 2022 17:58
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12912/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12912/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12912/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12912/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12912/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12912/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12912/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12912/merge#BCU1XR#0

@RaananW RaananW merged commit 209855c into BabylonJS:master Aug 30, 2022
@carolhmj carolhmj deleted the fixSVGImageLoading branch September 2, 2022 17:31
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@carolhmj
Add type on blob creation (#12912)
d40304a 
* Add type on blob creation

* Review.

Former-commit-id: 58b6dccc6f0a7505c3ecb6087217a74ede3409b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW Awaiting requested review from RaananW

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carolhmj @RaananW