-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "metadata" support to "ReflectionProbe" class #12911
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There is no need to update the "what's new.md" file. A changelog will be generated using the PR and its tags. |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12911/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12911/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12911/merge#BCU1XR#0 |
@@ -74,6 +74,11 @@ export class ReflectionProbe { | |||
@serializeAsVector3() | |||
public position = Vector3.Zero(); | |||
|
|||
/** | |||
* Gets or sets an object used to store user defined information for the sound. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: sound => probe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG nice catch, thanks!!
Former-commit-id: ef05293305573dd03cf67f04967657dc68a5efe3
No description provided.