Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug from opening editor from PG #12899

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Fixed a bug from opening editor from PG #12899

merged 2 commits into from
Aug 25, 2022

Conversation

amritanarasimhan
Copy link
Contributor

Responsive button was in the wrong state

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12899/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12899/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12899/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12899/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12899/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12899/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12899/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12899/merge#BCU1XR#0

@RaananW RaananW merged commit af81da3 into BabylonJS:master Aug 25, 2022
@RaananW
Copy link
Member

RaananW commented Aug 31, 2022

Requested by @amritanarasimhan

RaananW added a commit that referenced this pull request Aug 31, 2022
@RaananW
Revert "Fixed a bug from opening editor from PG (#12899)"
3719757 
This reverts commit af81da3.
@RaananW RaananW mentioned this pull request Aug 31, 2022
Merged
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@amritanarasimhan
Fixed a bug from opening editor from PG (#12899)
fbaf99f 
* responsive toggle is correct

* added code back in

Former-commit-id: cb65c0cc44f1e3dba86ccca7d60a6b2d0adf1757
RaananW added a commit that referenced this pull request Dec 9, 2022
@RaananW
Revert "Fixed a bug from opening editor from PG (#12899)"
21cacad 
This reverts commit fbaf99f [formerly cb65c0cc44f1e3dba86ccca7d60a6b2d0adf1757].


Former-commit-id: d6806dde8bd26d10b794ce923998dfcbb0ee4181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amritanarasimhan @RaananW