Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove tslib reference in es6 packages (First step towards esm) #12897

Merged
merged 4 commits into from
Aug 26, 2022
Merged

[Build] Remove tslib reference in es6 packages (First step towards esm) #12897

merged 4 commits into from
Aug 26, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Aug 24, 2022

Fixes #12784

This PR removes the tslib dependency (while still providing it locally in its es6 version). This will allow using the es6 packages in the browser directly and will minimally help tree shaking, as not all of tslib is even needed (ATM only decorators).

Another change - the output for the esm packages is no longer es5! it is now es2021.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

1 similar comment
@azure-pipelines
Copy link

Reviewer - this PR has made changes to one or more package.json files.

@azure-pipelines
Copy link

@RaananW RaananW merged commit 848cd84 into BabylonJS:master Aug 26, 2022
@RaananW RaananW deleted the RaananW/issue12784 branch August 26, 2022 12:08
@RaananW
Copy link
Member Author

RaananW commented Aug 26, 2022

@sebavan - no package was released yet that supports this. this is just a TODO list for both of us to quickly discuss side effects of this change

RaananW added a commit that referenced this pull request Dec 9, 2022
…m) (#12897)

* [Build] Remove tslib reference in es6 packages (First step towards esm)
Fixes #12784

* formatting

* fix for constants

* Update packages/dev/core/src/Engines/thinEngine.ts

Former-commit-id: b051ff4521424c8c7306fd509a60ff26c3b3075f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Remove tslib reference in es6 packages (First step towards esm)
1 participant