Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a FileButton to the InspectableTypes #12871

Merged

Conversation

kircher1
Copy link
Contributor

This playground would demo how to use it: https://www.babylonjs-playground.com/#XK769K#5

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid using console directly :-)

Also - what is the main reason to have something like that? What's the use-case?

…Grids/customPropertyGridComponent.tsx

Co-authored-by: Raanan Weber <[email protected]>
@RaananW
Copy link
Member

RaananW commented Aug 15, 2022

@sebavan - Tools is not imported, it was just a suggestion :-)
But I think it is more important to understand the need for that before

@sebavan
Copy link
Member

sebavan commented Aug 15, 2022

The need is to have a custom tool where you can load file like a custom texture loader for instance

@RaananW RaananW self-requested a review August 15, 2022 14:32
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 30cadb8 into BabylonJS:master Aug 15, 2022
@kircher1 kircher1 deleted the users/kircher1/file-button-inspectable branch August 26, 2022 17:41
RaananW pushed a commit that referenced this pull request Dec 9, 2022
…spectable

Adds a FileButton to the InspectableTypes

Former-commit-id: 63100387678d9c813073bd132b0842c17d22b28a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants