Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed scene tree not sticking #12754

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Conversation

amritanarasimhan
Copy link
Contributor

When clicking arrow button in scene tree, children were not appearing unless the mouse was moved

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12754/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh requested a review from RaananW July 15, 2022 20:04
@azure-pipelines
Copy link

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question about the code changes :-)

We can discuss that in a call if there is something wrong with my explanation.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

@carolhmj carolhmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change had an unintended side effect: in the master branch, if you select an item on the canvas that is not expanded on the scene tree, the scene tree automatically expands to show it:
ezgif-1-1bb5c33d2a

While on this branch, this behavior doesn't happen anymore:
ezgif-1-6c66610cd4

(The GUI I used is here: http://localhost:1338/#C9NT11#1)

@azure-pipelines
Copy link

@RaananW RaananW merged commit 9d3d72a into BabylonJS:master Jul 19, 2022
@amritanarasimhan amritanarasimhan deleted the issue176 branch July 19, 2022 21:34
@amritanarasimhan amritanarasimhan restored the issue176 branch July 19, 2022 21:34
RaananW pushed a commit that referenced this pull request Dec 9, 2022
* fixed scene tree not sticking

* got rid of unwanted code

* small code change

Former-commit-id: 0341672b5156b304ac17d4986e0cbe0e40c02895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants