Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XR] Do not style overlay if custom buttons provided #12738

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[XR] Do not style overlay if custom buttons provided #12738

merged 2 commits into from
Jul 13, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jul 12, 2022

No description provided.

@RaananW RaananW changed the title Do not style overlay if custom buttons provided [XR] Do not style overlay if custom buttons provided Jul 12, 2022
@carolhmj carolhmj enabled auto-merge July 12, 2022 16:42
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12738/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12738/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12738/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12738/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12738/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12738/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12738/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12738/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12738/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12738/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12738/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12738/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12738/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12738/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12738/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12738/merge#BCU1XR#0

@carolhmj carolhmj merged commit d78fc01 into BabylonJS:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolhmj carolhmj carolhmj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaananW @carolhmj