DeviceInputSystem: Fixed Passive Support Check to prevent Violation Warning #12696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a warning found by a user on the forums that, in Verbose mode, a Violation warning was occurring:
This warning was happening because the
wheel
event listener didn't have the "passive" option set to true when able. After closer investigation, it was found that the code used to determine if passive was supported was always returning false, causing this warning to occur. This PR modifies the logic to fix this.Forum link: https://forum.babylonjs.com/t/bjs-console-warnings-when-using-cleargizmoonemptypointerevent/31447/8