Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GLTF Animation serializer to include Camera. #12686

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Update GLTF Animation serializer to include Camera. #12686

merged 6 commits into from
Jul 7, 2022

Conversation

pandaGaume
Copy link
Contributor

Camera and Light was not exported to GLTF due to single test about TransformNode. We introduce a test function, which encompass test for TransformNode, Camera and Light. This test function will evolve to add support for KHR_animation_pointer.
See this forum thread.

@pandaGaume pandaGaume added the bug label Jun 28, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

sebavan
sebavan approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding Gary for final review as well

@sebavan sebavan requested a review from bghgary June 28, 2022 15:02
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

@azure-pipelines
Copy link

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

@deltakosh
Copy link
Contributor

@bghgary can we merge this one?

@bghgary bghgary marked this pull request as draft July 6, 2022 16:37
@bghgary
Copy link
Contributor

bghgary commented Jul 6, 2022

Not yet. I've marked it as draft.

@pandaGaume
Copy link
Contributor Author

Just tell me what you want me to change, then we can close it.

@bghgary
Copy link
Contributor

bghgary commented Jul 6, 2022

I think I would remove the TransformableType as it doesn't really help compared to using Node directly. And then just cast to TransformNode in the _GetBasePositionRotationOrScale function to avoid misspelling.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bghgary bghgary marked this pull request as ready for review July 6, 2022 19:22
@bghgary bghgary enabled auto-merge (squash) July 6, 2022 19:23
@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12686/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12686/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12686/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12686/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12686/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12686/merge#BCU1XR#0

@pandaGaume
Copy link
Contributor Author

@bghgary modifications done.

@bghgary bghgary merged commit 5c12ba9 into BabylonJS:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW left review comments

@bghgary bghgary bghgary approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pandaGaume @deltakosh @bghgary @RaananW @sebavan