Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] make sure component init before render #12651

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[GUI] make sure component init before render #12651

merged 1 commit into from
Jun 14, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jun 14, 2022

Reproduction:

This playground fails - https://www.babylonjs-playground.com/#XCPP9Y#13718

Because when setting the radius we are setting everything as dirty (including the fontOffset-related function, even though fontOffset is not yet set).

fontOffset is being set when the UI element is being rendered. In this playground the initial state of the component is hidden (it is outside of the frustum).

@RaananW RaananW added the bug label Jun 14, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 226cb80 into BabylonJS:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants