-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a few methods to Quaternion and Vector3 #12598
Conversation
- lengthSquared - subtractInPlace - normalizeToNew
- invert - invertInPlace
- applyRotationQuaternionToRef - applyRotationQuaternionInPlace - applyRotationQuaternion
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Good job! |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12598/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge#BCU1XR#0 |
Head branch was pushed to by a user without write access
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12598/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge#BCU1XR#0 |
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12598/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12598/merge#BCU1XR#0 |
* Update .gitignore * Added methods to Quaternion - lengthSquared - subtractInPlace - normalizeToNew * Added methods to Quaternion - invert - invertInPlace * added Quaternion transformations - applyRotationQuaternionToRef - applyRotationQuaternionInPlace - applyRotationQuaternion * aligning with braces conventions * Prettier code * added return annotations in tsdoc
I noticed there was a few useful methods not implemented regarding transformations of Vector3 by Quaternions.
Here is what I added :
Quaternion
subtractInPlace
invertInPlace
invert
normalizeToNew
lengthSquared
Vector3
applyRotationQuaternionToRef
applyRotationQuaternionInPlace
applyRotationQuaternion
Other